etcdserver: handle proposal error when processing internal raft request #9549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. can you fix CI failure? |
|
@nolouch I just rebased. Merging in CI greens. Thanks! |
gyuho
force-pushed
the
handle-fail
branch
5 times, most recently
from
1415e8d to
b049faa
Compare
Signed-off-by: Gyuho Lee <[email protected]>
Signed-off-by: Gyuho Lee <[email protected]>
|
I've pushed another commit fixing a minor typo with changelog. All test suites passed including functional test https://semaphoreci.com/coreos/etcd/branches/pull-request-9549/builds/6. Merging. Thanks. |
Codecov Report
@@ Coverage Diff @@
## master #9549 +/- ##
=========================================
Coverage ? 72.27%
=========================================
Files ? 368
Lines ? 31339
Branches ? 0
=========================================
Hits ? 22649
Misses ? 7041
Partials ? 1649
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after #9137 merged, may need to handle the proposal error in etcdserver.
This will be used to fix issue: #8975